General Forum |
 |
PSA: Don't use Discover Albia's C1 RCBs | |
| 
GimmeCat
  
|
12/22/2020 | 5 |
Just a heads-up, not sure if this has been talked about before but I was poking around the "Updated <Food>" cobs (which are fantastic, btw) and discovered something pretty horrendous. The included RCB files, which as you'll know for C1 are the removal scripts, contain an erroneous command that could seriously harm your game.
For example, this is the code for Updated Cheese's RCB:
inst
enum 2 6 1
kill targ
next
enum
kill targ
next
endm |
Spot the problem? It's that blank enum. This script is essentially looping through every single object in the game (including system scripts) and attempting to delete it! It's armageddon!
On top of this, it also deletes the scripts that handle the eating, activating, dropping etc of the food items. Which is typically good practice, except these cobs overwrite the default food scripts, and the removers do not re-inject the originals. So if you remove, them you're left with completely non-functional cheese, carrot, and lemon objects.
As expected, using this script caused an instant crash when I tried it. Luckily I had a backup of my world, and while I don't think it would have been harmed by the crash, you can never be too sure. It's very easy for data to become corrupted when a program terminates unexpectedly, especially in a game where you're never sure when it's in the process of saving!
So, this post is just to warn everyone that the removers are dangerous. But the cobs themselves are still worth using! So much so, that I wonder if anyone had ever attempted to remove them, which is probably why this major script error went unnoticed by the author!
In closing, it is a great idea to familiarise yourself with basic COBbing, and use a program like BoBCob to inspect any objects you download before using them in your game. Even if they come from a well-trusted source--mistakes happen!
|
 Peppery One
Papriko
    
|
12/22/2020 | 1 |
I mean, yeah, that is a problem, but does it really try to terminate everything? Admittedly, I never played C1, but in C3/DS it would crash due to invalid argument types and numbers. You'd have to explicitly define 0 0 0 as classifier wildcards.
The way it is written there, it would ignore the line break and try to read kill targ as the agent family and then stumble because that's a command, not a numeric value.
Still a grave oversight none the less.
Lets play plants! Photosynthesis... Photosynthesis... Photosynthesis... |

GimmeCat
  
|
12/22/2020 | |
The error I received was one of those "during execution of a macro" rather than a syntax error, so that led me to believe it really tried to delete something. You could be right, though.
In any case, having your game crash is never a good thing, and progress could be lost if it hasn't saved in a while. |

Malkin
     Manager

|
12/22/2020 | |
How hard would it be to patch?
My TCR Norns |

GimmeCat
  
|
12/23/2020 | 2 |
Very easy. I would've done it myself but I'm in the middle of a large project that I'm trying to get ready for Xmas. |

Carminechimera

|
12/26/2020 | |
Oof... glad I noticed this. I just got C1 again & I JUST downloaded the carrots & cheese fixes. I'm not completely sure what all it affects with every "updated" food item so I guess I'll hold off for now.
"Gob swear- if me see ONE more potato in house..." |
|